zobnin / aio

AIO Launcher page for bug reports and suggestions
17 stars 1 forks source link

Extracted colors from wallpaper often have poor contrast #5

Closed trev-dev closed 2 years ago

trev-dev commented 2 years ago

I really like the "extracted wallpaper" colors feature. The only issue I have with it is if the background is on the darker side, the extraction chooses the a pretty dark hex based on the majority of the background color.

This makes the extracted color a pretty poor contrasting color all of the darker themes...which are the majority of the themes. You can barely see the progress bars/timer buttons as a result. Even in lighter backgrounds the derived color is pretty dark.

It would be nice if the color that gets extracted is compared to the "background overlay" for contrast, then adjusted before its applied.

Screenshot_20220207-220246

Screenshot_20220207-220858

Screenshot_20220207-221406

zobnin commented 2 years ago

This is because the color selection algorithm intentionally corrects colors so that they are well suited for displaying white text over them (switch the theme to Flat and you'll see why). And yes, it might be worth calibrating it to display more correctly in Neon-type styles.

trev-dev commented 2 years ago

I customized the theme to use the classic progress bars and it does help a bit.

Screenshot_20220208-095842-996.png

zobnin commented 2 years ago

I have added wallpaper color calibration for Neon-like themes in version 4.3.2-beta9. Please try it.

trev-dev commented 2 years ago

It's a huge improvement

Screenshot_20220217-225144-882.png

Screenshot_20220217-224820~2.png

trev-dev commented 2 years ago

Even the backgrounds that are super bright are not creating colors that wash out the text/theme.

Great work 👏

Screenshot_20220217-225714-023.png