zobristnicholas
commented
2 years ago The old PR is here if you want to look link. This version looks better. It still needs:
- a test function
- a doc string (there are a lot of parameters for the xml generation that aren't easily understood)
- you shouldn't need a folder argument. The sonnet file folder will be stored in self.self.project_file_path. Check that it is set first. It may be
Noneif the sonnet file hasn't been written yet.
Okay. So my computation skills are really being tested here. I have fixed the indentation. Your pervious comments were erased so I cant implement all that you said. I remember a comment about the kwargs. There are defined in the same ways you define yours in the code. Or did you want them to be defined as self.whatever = whatever, or something like that? Also for the try: and finally:, did that come right before I collect the command run? Also I dont know how to get ride of the sonnet_file and rather direct the code to the location of the file. Thats why I thought the variable is just like a place holder for whenever someone wants to use this function on there own files places wherever they want to place them? Not sure if I am making any sense