search

zocker-160 / keyboard-center

Application for mapping macro keys on Logitech keyboards
GNU General Public License v3.0
65 stars 2 forks source link

Using Super Key as Custom Modifier Deletes All Settings #54

Closed scott-carrion closed 9 months ago

scott-carrion commented 10 months ago

First of all, excellent project. It works great, and having this work nicely with OpenRGB makes for a seamless solution for complete control over my devices that is actually better in terms of quality and feature set than the official, bloated, Windows-only "software".

Here's the bug I found: Attempting to use the super (Windows) key as a custom modifier for a macro results in the settings.yml file being completely deleted.

Using Debian Bookworm and i3 (with GNOME installed as well), keyboard-center version 1.0.5.

I don't know if this has anything to do with it, but I have a Logitech G815 keyboard.

image

zocker-160 commented 10 months ago

oh god thanks for reporting, this is really bad, will fix asap.

The Windows / Super key should not be allowed in the custom modifier in the first place as it is already under the primary modifiers as "Meta". Maybe I should rename that button as well to make it more clear.

Ofc this should never nuke the settings file :V.

EDIT: found the issue, will push a fixed version in the upcoming days

zocker-160 commented 9 months ago

fixed in 1.0.6

scott-carrion commented 9 months ago

Just wanted to confirm that this issue is indeed fixed in 1.0.6 (great turnaround time by the way!)

I retested and now see that the "Meta/Super" key is clearly labeled now, and that upon hovering over the button, it now reads "aka the Windows key".

Ignoring this and trying to use the Super (aka Windows) key as a custom modifier is correctly denied: Nothing happens when you press it.