search

zocker-160 / thinkfan-ui

A small gui app for Linux to control the fan speed and monitor temps on a ThinkPad
GNU General Public License v3.0
88 stars 8 forks source link

thinkfan-ui crashes when clicking "full throttle" #7

Closed FantasyPvP closed 1 year ago

FantasyPvP commented 1 year ago

my device is a thinkpad x1 yoga gen3, should thinkfan work for this device?

FantasyPvP commented 1 year ago

i'm running arch with zen kernel 6.3.8 if that matters?

zocker-160 commented 1 year ago

Could you start with a terminal in command line and then press full throttle and give me the terminal output?

That would be really helpful to find out what is going wrong.

EDIT: This app works with any device supported by the thinkpad-acpi kernel module.

FantasyPvP commented 1 year ago

image here's the screenshot, does this error mean my system isn't supported? like I said, I'm running the latest zen kernel so maybe it doesnt support the thinkpad-acpi patch?

(clicking the auto setting also results in the same error)

zocker-160 commented 1 year ago

ah I see, I remember seeing this issue some time ago already.

I guess the problem is that your shell does not seem to support the "$@" syntax, if you remove in /usr/bin/thinkfan-ui, it should start.

I had to add it in order to make commandline arguments work and weirdly enough it just does not work with some terminal emulators.

This is an issue that I wanted to fix by moving away from using a launch bash script.

That being said, "$@" is valid POSIX syntax and should be reported as a bug to the terminal / shell emulator.

zocker-160 commented 1 year ago

yep it is actually a duplicate of #3, the error looks exactly the same.

FantasyPvP commented 1 year ago

ah I see, I remember seeing this issue some time ago already.

I guess the problem is that your shell does not seem to support the "$@" syntax, if you remove in /usr/bin/thinkfan-ui, it should start.

I had to add it in order to make commandline arguments work and weirdly enough it just does not work with some terminal emulators.

This is an issue that I wanted to fix by moving away from using a launch bash script.

That being said, "$@" is valid POSIX syntax and should be reported as a bug to the terminal / shell emulator.

Just so you know I'm using bash with alacritty which I believe is quite a popular combination so there's probably quite a few people who would be affected

zocker-160 commented 1 year ago

understood, thank you for that information, I will try to reproduce that issue (which so far I sadly have not been able to)

zocker-160 commented 1 year ago

I am sadly not able to reproduce this with bash + alacritty.

zocker-160 commented 1 year ago

This issue should be fixed with the latest version. The problem is that both the DEB and the AUR package don't initialize the thinkpad_acpi kernel module correctly.