search

zodb / relstorage

A backend for ZODB that stores pickles in a relational database.
Other
53 stars 46 forks source link

FIPS Support #481

Closed frapell closed 2 years ago

frapell commented 2 years ago

This is for gh-480

jamadden commented 2 years ago

There are some lint errors to take care of, with the change from a stdlib import to a custom import:

************* Module relstorage._compat
relstorage/_compat.py:30: [C0411(wrong-import-order), ] standard import "from functools import partial" should be placed before "import BTrees"
relstorage/_compat.py:31: [C0411(wrong-import-order), ] standard import "from hashlib import md5 as md5_original" should be placed before "import BTrees"
************* Module relstorage.tests.blob.testblob
relstorage/tests/blob/testblob.py:29: [C0411(wrong-import-order), ] third party import "import transaction" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:30: [C0411(wrong-import-order), ] third party import "import ZODB.blob" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:31: [C0411(wrong-import-order), ] third party import "import ZODB.interfaces" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:32: [C0411(wrong-import-order), ] third party import "import ZODB.tests.StorageTestBase" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:33: [C0411(wrong-import-order), ] third party import "import ZODB.tests.util" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:34: [C0411(wrong-import-order), ] third party import "from ZODB.blob import Blob" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:35: [C0411(wrong-import-order), ] third party import "from ZODB.DB import DB" should be placed before "from relstorage._compat import md5"
relstorage/tests/blob/testblob.py:36: [C0411(wrong-import-order), ] third party import "from ZODB.serialize import referencesf" should be placed before "from relstorage._compat import md5"

Unfortunately, there's not a tox environment that runs the linter (I'll add one), but you can run it locally (from the Python 3 virtualenv you have relstorage installed in) with:

pip install -U pylint
python -m pylint --rcfile=.pylintrc relstorage

Unfortunately, I can't update this PR myself for some reason, or I'd just go ahead and fix it. But you can cherry-pick the commit https://github.com/zodb/relstorage/commit/12b663baa632ad09e8a79e7bf7e4a99041d4bdd2 to fix it.

jamadden commented 2 years ago

Thanks! The test failure on GHA is due to an unrelated problem. AppVeyor all passed.