search

zodern / meteor-up

Production Quality Meteor Deployment to Anywhere
http://meteor-up.com/
MIT License
1.27k stars 281 forks source link

Expose container port without ssl or proxy #1199

Open maruns opened 3 years ago

maruns commented 3 years ago

I have a few applications. I have external (to mup) load balancer which handles ssl. I use custom docker network as only transport.

I would like to just deploy meteor application container without proxy or ssl containers and expose the port on docker network. This way I won't need to track which port on localhost is bound to which application.

Currently mup in meteor plugin's start.sh at line 77 is doing 

<% if((sslConfig && typeof sslConfig.autogenerate === "object") || (typeof proxyConfig === "object" && !proxyConfig.loadBalancing)) { %>

I propose to add a new option to meteor plugin docker.expose which will by default by falsy and can be set to true. This would allow to change the above mentioned line into

<% if((sslConfig && typeof sslConfig.autogenerate === "object") || (typeof proxyConfig === "object" && !proxyConfig.loadBalancing) || docker.expose ) { %>

Proposed changes are implemented https://github.com/maruns/meteor-up/commit/c3b52cb2e1fb86018b4dd0fead00aaeefdcfe370.

If you think it looks fine I'll update documentation and rise PR.

Disclaimer: It works for me. I didn't manage yet to run test because I use podman on daily basis.