Fix/docker private registry login

zodern / meteor-up

Production Quality Meteor Deployment to Anywhere

http://meteor-up.com/

MIT License

1.27k stars 281 forks source link

Fix/docker private registry login #1213

Closed djbelieny closed 3 years ago

djbelieny commented 3 years ago

Whenever mup was set to use private docker registry, the bash scripts that prepare the build and start meteor app were not login into the correct docker registry to push the built images. The builds were failing authentication. This pull request changes the bash scripts to run a docker login whenever the script sees that the privateRegistry data is available.

djbelieny commented 3 years ago

Noticed that there was a bunch of unrelated stuff commented to the PR. I will redo it with just my code.