zodern / meteor-up

Production Quality Meteor Deployment to Anywhere
http://meteor-up.com/
MIT License
1.27k stars 281 forks source link

Support 'shell' specification for mup hooks #1223

Open wallind opened 3 years ago

wallind commented 3 years ago

The underlying code for the hooks functionality uses Node's child_process.execSync

image

I want to extend the hooks capability to allow specification of the shell option like below. I will set it up as an optional param of course. image

The reason for wanting this is so that I can focus on writing only one version of the hook which various devs on different OS's can still use by specifying the shell to a shell which supports the hook. In the specific case of what I'm working on right now I want the hook to work for other devs on the team which use Mac; but I use Windows. I do however have access to GitBash on Windows which will allow me again to only write one version of the hook itself. I will just leave the shell option commented to allow Windows devs to quickly be able to use the same mup.js deployment