zodern / meteor-up

Production Quality Meteor Deployment to Anywhere
http://meteor-up.com/
MIT License
1.28k stars 279 forks source link

Please bump ssh2 version #1300

Open kurvenschubser opened 2 years ago

kurvenschubser commented 2 years ago

Hi I believe the error below could be due to a rather tight security setting in SSHD on the server. I know MUP is supposed to work with a Ubuntu server's default configuration, but I'll ask anyway: would an upgrade of the ssh2 package solve this problem and if yes, would you be willing to bump the version?

Mup version (mup --version): 1.5.7

Mup config

{
  "servers": {
    "one": {
      "host": "1.2.3.4",
      "username": "root"
    }
  },
  "app": {
    "name": "my-app",
    "path": "../",
    "servers": {
      "one": {}
    },
    "buildOptions": {
      "serverOnly": true,
      "buildLocation": "/tmp/mup-meteor-38d47443-ae21-44c9-9367-3756da4528c3",
      "cleanBuildLocation": true
    },
    "env": {
      "ROOT_URL": "https://subdomain.host.com",
      "MONGO_URL": "mongodb://mongodb:27017/my-app",
      "MONGO_OPLOG_URL": "mongodb://mongodb/local",
      "ADMIN_EMAIL": "[stripped]",
      "MAIL_URL": "[stripped]",
      "VIRTUAL_HOST": "subdomain.host.com",
      "HTTPS_METHOD": "redirect",
      "LETSENCRYPT_HOST": "subdomain.host.com",
      "LETSENCRYPT_EMAIL": "email@domain.com",
      "VIRTUAL_PORT": 3000,
      "HTTP_FORWARDED_COUNT": 1
    },
    "docker": {
      "image": "zodern/meteor",
      "stopAppDuringPrepareBundle": true,
      "imagePort": 3000,
      "args": [
        "--link=mongodb:mongodb"
      ]
    },
    "volumes": {
      "/home/app/uploads": "/home/app/uploads"
    },
    "enableUploadProgressBar": true,
    "type": "meteor"
  },
  "mongo": {
    "version": "3.6.23",
    "servers": {
      "one": {}
    },
    "dbName": "dbname"
  },
  "proxy": {
    "servers": {
      "one": {}
    },
    "domains": "subdomain.host.com",
    "ssl": {
      "letsEncryptEmail": "email@domain.com",
      "forceSSL": true
    }
  }
}

Output of command $ mup deploy --config=mup-production.js --cached-build

Not building app. Using build from previous deploy at
/tmp/mup-meteor-38d47443-ae21-44c9-9367-3756da4528c3

Started TaskList: Pushing Meteor App
[116.203.94.62] - Pushing Meteor App Bundle to the Server
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error: Handshake failed: no matching client->server HMAC
    at check_KEXINIT (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:2458:15)
    at check (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:2281:9)
    at onKEXINIT (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:2277:5)
    at SSH2Stream.<anonymous> (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:208:5)
    at SSH2Stream.emit (events.js:314:20)
    at parse_KEXINIT (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:3870:8)
    at parsePacket (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:3766:12)
    at SSH2Stream._transform (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:701:13)
    at SSH2Stream.Transform._read (_stream_transform.js:191:10)
    at SSH2Stream._read (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:253:15)
    at SSH2Stream.Transform._write (_stream_transform.js:179:12)
    at doWrite (_stream_writable.js:403:12)
    at writeOrBuffer (_stream_writable.js:387:5)
    at SSH2Stream.Writable.write (_stream_writable.js:318:11)
    at Socket.ondata (_stream_readable.js:718:22)
    at Socket.emit (events.js:314:20)
Emitted 'error' event on Client instance at:
    at SSH2Stream.<anonymous> (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2/lib/client.js:359:10)
    at SSH2Stream.emit (events.js:326:22)
    at check_KEXINIT (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:2460:10)
    at check (/home/malte/.nvm/versions/node/v12.22.9/lib/node_modules/mup/node_modules/ssh2-streams/lib/ssh.js:2281:9)
    [... lines matching original stack trace ...]
    at SSH2Stream.Writable.write (_stream_writable.js:318:11) {
  level: 'handshake'
}