search

zodern / mup-redis

Plugin for Meteor Up to setup and manage Redis
MIT License
7 stars 5 forks source link

Support for redis oplog #1

Closed emenoh closed 4 years ago

emenoh commented 6 years ago

Using a redis oplog rather than Mongo oplog is becoming a popular option.

https://github.com/cult-of-coders/redis-oplog

It's not clear if such a use case would work with this. Does the --append-only flag interfere? Currently I'm using a separate redis docker image for this. Any thoughts?

zodern commented 6 years ago

Currently, this plugin only supports the Meteor app running on one server. After Meteor Up 1.5, I will add support for using mup-redis when running an app on multiple servers, and look into if any changes need to be made to support redis-oplog.

pagesrichie commented 6 years ago

Will this work with https://github.com/zodern/mup-aws-beanstalk and/or will there be a redis option over there? Love your mup-aws-beanstalk!!

edemaine commented 4 years ago

I'm looking to switch my applications to redis-oplog, so came across this discussion again. The how it works document says "We don't use Redis as a database, we do not store anything in it." which suggests we really don't want Redis persistence turned on.

Could we make the persistence mode configurable in this plugin? Or perhaps it doesn't matter, if nothing is actually getting written to the database?

edemaine commented 4 years ago

FWIW, I just got Redis Oplog (with Redos 6.0.8-alpine) working fine with this plugin (with Meteor, Mongo, Redis all running on the same machine). I just needed the following to settings.json:

{
  "redisOplog": {
    "redis": {
      "host": "redis",
      "port": 6379
    }
  }
}

(The default hostname otherwise is 127.0.0.1 which doesn't work because of Docker.) Perhaps worth adding to the README? I can write a PR.

Could we make the persistence mode configurable in this plugin? Or perhaps it doesn't matter, if nothing is actually getting written to the database?

After many pub/sub events, I can confirm that /opt/redis/data/appendonly.aof is 0 bytes, so I don't think this library needs any changes (and perhaps this issue should be closed?).