search

zoetrope69 / letterboxd

:movie_camera::clapper: get public diary data for letterboxd users
51 stars 9 forks source link

Support Markdown review format #188

Open dirtystylus opened 8 months ago

dirtystylus commented 8 months ago

Hi—I’m working on a project (https://www.markllobrera.com/posts/letterboxd-to-markdown/) and I wanted the review to be in Markdown format, so I took a stab at implementing that. It uses a reviewFormat parameter and if that is set to markdown I call a new method getReviewAsMarkdown(). There’s probably a more elegant way to do this, but happy to discuss my use case if you have questions!

zoetrope69 commented 8 months ago

Great stuff, I like the usecase of Eleventy

Do you think we could add a basic test for this and add the new parameter to the documentation. An example of the output in the README would be good?

dirtystylus commented 8 months ago

@zoetrope69 Hi! Clarifying: were you asking for my assistance for either or both of those items (I think both are worthwhile)?

I can help with the README part. I’m not as familiar with writing tests for node so would defer to you for that aspect (happy to learn, though)

zoetrope69 commented 7 months ago

sure, i can write the tests if you update the readme

zoetrope69 commented 7 months ago

thank you!

dirtystylus commented 7 months ago

@zoetrope69 Updated the README!