search

zoeydawn / coin-ticker

Wrapper for bitcoin exchange apis. The easiest way to add cryptocurrency market data into your application!
https://www.npmjs.com/package/coin-ticker
45 stars 22 forks source link

Standardize pairs #6

Closed passabilities closed 7 years ago

passabilities commented 7 years ago

Requires a merge on #5

zoeydawn commented 7 years ago

@passabilities thanks for your PRs! Will the original lowercase pair structure with no underscore still work for all exchanges? I like what you have done, I just want to make sure that an update will not break apps already depending on this package.

passabilities commented 7 years ago

Unfortunately, no the original lowercase format will no longer work in this instance. That is due to removing the avaliablePairs array that was defined in the exchange files. I did that so that the user is not limited by the what is defined in that array but rather any pair that the exchange offers. This just allows for more flexibility for when the exchanges expand and add more pairs. Doesn't have to be done like this just something I thought would work best.

In order to get around making sure this doesn't break for existing apps using this package, we could just bump the version number.