As the title says, fix for issue #431.
This also has a significant yet simple performance improvement to the loop gathering the data/rows from $this->source for the PDOStatement on lines 212:215 of DataSet::build(), by simply getting out of the loop as soon as all required records have been collected. My mistake for not including this in my initial PR.
Note: I am working on #430, but it is probably better and easier to understand if the PR's are kept to small units.
As the title says, fix for issue #431. This also has a significant yet simple performance improvement to the loop gathering the data/rows from
$this->sourcefor the PDOStatement on lines 212:215 of DataSet::build(), by simply getting out of the loop as soon as all required records have been collected. My mistake for not including this in my initial PR.Note: I am working on #430, but it is probably better and easier to understand if the PR's are kept to small units.
Cheers. /s