zoffixznet / HTML-ExtractText

HTML::ExtractText perl module for extracting specific bits of text from HTML using CSS selectors
0 stars 0 forks source link

Tests started to fail (with Mojolicious 7.34+?) #15

Open eserte opened 7 years ago

eserte commented 7 years ago

The test suite started to fail:

#   Failed test 'return of ->extract'
#   at t/01-extract.t line 42.
# Compared $data->{"p"}
#    got : '
# '
# expect : 'Paras1
# Paras2'

#   Failed test 'hash interpolation of object'
#   at t/01-extract.t line 43.
# Compared $data->{"p"}
#    got : '
# '
# expect : 'Paras1
# Paras2'
(etc.)

Statistical analysis suggests that the failures started with Mojolicious 7.34 --- however, I don't see a removal notice in Mojolicious' Changes file (@kraih FYI):

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    67452425199696400.00
[1='eq_7.10']         0.0000          0.0000       0.17
[2='eq_7.12']         0.0000          0.0000       0.00
[3='eq_7.14']         0.0000          0.0000       0.69
[4='eq_7.18']         0.0000          0.0000       0.69
[5='eq_7.19']        -0.0000          0.0000      -0.28
[6='eq_7.20']         0.0000          0.0000       0.66
[7='eq_7.21']         0.0000          0.0000       0.95
[8='eq_7.26']         0.0000          0.0000       1.32
[9='eq_7.28']         0.0000          0.0000       1.15
[10='eq_7.30']       -0.0000          0.0000      -1.58
[11='eq_7.31']       -0.0000          0.0000      -1.40
[12='eq_7.33']        0.0000          0.0000       0.00
[13='eq_7.34']       -1.0000          0.0000    -11924016816545926.00
[14='eq_7.35']       -1.0000          0.0000    -30549932780388972.00

R^2= 1.000, N= 86, K= 15
****************************************************************
kraih commented 7 years ago

This module relies on internal Mojo::DOM functions, those will break all the time.