zoffixznet / JavaScript-Minifier

JavaScript::Minifier perl module
9 stars 6 forks source link

dont work if url in script #13

Open arnold-b opened 4 months ago

arnold-b commented 4 months ago

just try this to minify if (item) { let copyText = "https://www.xxx.com/index.html?itemno="+item.value; navigator.clipboard.writeText(copyText); } after // the minifier will cut all because he interpret this as comment minify result: let copyText = "https:navigator.clipboard.writeText(copyText);}}

zoffixznet commented 4 months ago

You may be using an outdated version of the module. When I minify your example with fresh module install from CPAN, it comes out fine:

perl -MJavaScript::Minifier -wlE '                                                                                                                                                            
    say "Using module version " . $JavaScript::Minifier::VERSION;                                                                                                                                                                          
    say "Minified code: " . minify(input => q|if (item) { let copyText = "https://www.xxx.com/index.html?itemno="+item.value; navigator.clipboard.writeText(copyText); } |);                                                               
'                                                                                                                                                                                                                                          
Using module version 1.16                                                                                                                                                                                                                  
Minified code: if(item){let copyText="https://www.xxx.com/index.html?itemno="+item.value;navigator.clipboard.writeText(copyText);}
arnold-b commented 4 months ago

JavaScript::Minifier

    (no description)
    Z/ZO/ZOFFIX/JavaScript-Minifier-1.16.tar.gz
    /usr/local/share/perl/5.34.0/JavaScript/Minifier.pm
    Installed: 1.16
    CPAN:      1.16  up to date
    Zoffix Znet (ZOFFIX)
    zoffixcpan@gmail.com
arnold-b commented 4 months ago

Hello, JavaScript::Minifier


    (no description)

    Z/ZO/ZOFFIX/JavaScript-Minifier-1.16.tar.gz

    /usr/local/share/perl/5.34.0/JavaScript/Minifier.pm

    Installed: 1.16

    CPAN:      1.16  up to date

Von: Zoffix Znet @.> Gesendet: Sonntag, 26. Mai 2024 17:24 An: zoffixznet/JavaScript-Minifier @.> Cc: arnold-b @.>; Author @.> Betreff: Re: [zoffixznet/JavaScript-Minifier] dont work if url in script (Issue #13)

You may be using an outdated version of the module. When I minify your example with fresh module install from CPAN, it comes out fine:

perl -MJavaScript::Minifier -wlE '
say "Using module version " . $JavaScript::Minifier::VERSION;
say "Minified code: " . minify(input => q|if (item) { let copyText = "https://www.xxx.com/index.html?itemno="+item.value; navigator.clipboard.writeText(copyText); } |);
'
Using module version 1.16
Minified code: if(item){let copyText="https://www.xxx.com/index.html?itemno="+item.value;navigator.clipboard.writeText(copyText);}

— Reply to this email directly, view it on GitHub https://github.com/zoffixznet/JavaScript-Minifier/issues/13#issuecomment-2132258318 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2N3WNCXHLXZ2CPOKLS4TLZEH5CLAVCNFSM6AAAAABIGDWPMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGI2TQMZRHA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AH2N3WJSL6QYIJF376WZ4H3ZEH5CLA5CNFSM6AAAAABIGDWPMWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7C6XA4.gif Message ID: @. @.> >

zoffixznet commented 3 months ago

What output do you get when you run this code snippet:

perl -MJavaScript::Minifier -wlE '                                                                                                                                                            
    say "Using module version " . $JavaScript::Minifier::VERSION;                                                                                                                                                                          
    say "Minified code: " . minify(input => q|if (item) { let copyText = "https://www.xxx.com/index.html?itemno="+item.value; navigator.clipboard.writeText(copyText); } |);                                                               
'