Closed davorg closed 9 years ago
The synopsis for this module says that you use it like this:
use JavaScript::Minifier qw(minify);
But in the actual code, we have this:
our @EXPORT = qw(minify);
Which means that you'll get the minify() subroutine exported if you just use the module. You don't have to explicitly request the export.
minify()
I suggest that you either change the synopsis to say:
use JavaScript::Minifier;
Or change the code to use @EXPORT_OK rather than @EXPORT.
@EXPORT_OK
@EXPORT
our @EXPORT_OK = qw(minify);
If it helps, I discovered this discrepancy while answering this question on SO - http://stackoverflow.com/questions/27391659/avoiding-collisions-with-modules-with-same-method-names/27398939
Fixed and shipped to CPAN. Thanks all.
The synopsis for this module says that you use it like this:
But in the actual code, we have this:
Which means that you'll get the
minify()
subroutine exported if you just use the module. You don't have to explicitly request the export.I suggest that you either change the synopsis to say:
Or change the code to use
@EXPORT_OK
rather than@EXPORT
.If it helps, I discovered this discrepancy while answering this question on SO - http://stackoverflow.com/questions/27391659/avoiding-collisions-with-modules-with-same-method-names/27398939