search

zoffline / zwift-offline

Use Zwift offline
GNU Affero General Public License v3.0
721 stars 116 forks source link

Change Dockerfile to use local repo instead of master #345

Closed peteh closed 2 months ago

peteh commented 3 months ago

Instead of always pulling the latest master this dockerfile is building from the current state of the locally cloned repo.

This allows to develop on the code and then directly build the local code as a docker using docker compose build.

I'm not sure if there was a reasoning in letting the Dockerfile always pull the latest master or if it's ok to build from the current state of the repo.

If there was a reason to always clone master, then feel free to reject this PR.

oldnapalm commented 2 months ago

I'm not sure if there was a reasoning in letting the Dockerfile always pull the latest master or if it's ok to build from the current state of the repo.

I don't know why, it's like this since the initial commit, maybe because the image used to be built by Docker Hub when it was free, but since https://github.com/zoffline/zwift-offline/commit/32264ab0b9fde9f62e7ca31f6ee62525cf1012a3 it uses GitHub actions. I'm merging this to test.