search

zoglmannk / Morse-Code-Ninja

Software used to generate Morse Code Ninja practice sets as found on https://morsecode.ninja/practice/index.html
https://morsecode.ninja
GNU General Public License v3.0
32 stars 14 forks source link

use environment variables for AWS creds instead of a local configuration file #4

Closed sklegg closed 3 years ago

sklegg commented 3 years ago

another slight modification that should improve usability of this script inside a docker container

zoglmannk commented 3 years ago

I will be happy to take a look again once the merge conflicts are handled. Luckily they aren't too bad.

sklegg commented 3 years ago

My latest changes should support both the aws.properties file and environment variables.

zoglmannk commented 3 years ago

The code changes look good. I will double check to make sure that everything still works this evening after work.

zoglmannk commented 3 years ago

Temporarily merging this to another branch. There is one small change that needs to be done before merging into master.

zoglmannk commented 3 years ago

This has now been merged into master

zoglmannk commented 3 years ago

Okay. everything should be good to go. Note for consistency, I changed AWS_SECRET_KEY to AWS_SECRET_ACCESS_KEY.