search

zohararad / wysihtml5n

wysihtml5 powered rich-text editor with drag & drop image editing
http://zohararad.github.com/wysihtml5n
MIT License
41 stars 8 forks source link

Updating to Bootstrap 3 #4

Closed gbaudoin closed 7 years ago

gbaudoin commented 10 years ago

The current version is made for Bootstrap 2.

I'm trying to have it working with bootstrap 3 - so far, only the modal of insertImage and insertLink window seems to be of trouble.

zohararad commented 10 years ago

I'm happy to accept a pull request that updates to Bootstrap 3

cbielich commented 7 years ago

FYI I edited your project and the changes are now Bootstrap 3 compatible. Also a suggestion on usage it might be beneficial to let users know if they are using ajax to upload the BASE64 image they need to do it the right way like this

data: {image: image},

and not like the old school way, it will break

data: 'image='+image+

zohararad commented 7 years ago

Thanks a lot! Is there a PR with this change?

cbielich commented 7 years ago

lol I don't do GitHub much, what is PR?

gbaudoin commented 7 years ago

If you want to create a pull request between the patch-3 branch of your fork and zoharad's base, go to https://github.com/zohararad/wysihtml5n/compare/master...cbielich:patch-3

cbielich commented 7 years ago

Ok its done, you should see it

zohararad commented 7 years ago

ok to close this one?

gbaudoin commented 7 years ago

Closing ! #6 Thanks @cbielich for the pull and @zohararad for the merge !