search

zoharhen / Cocktails

0 stars 0 forks source link

searchView fix #76

Closed zoharhen closed 4 years ago

zoharhen commented 4 years ago
  1. replace GetScreenShot method with an asyncTask + add loading animation while waiting
  2. fix preparation layout bug
  3. clear searchView after filtering
zoharhen commented 4 years ago

@shahafhermann @enavhasson I made a few changes that might resolve the blink error when switching between fragments. please run the bug scenario one more time, and write the results here. IMO, if this is just a one second blink, which happens only one time - lets keep it that way.

shahafhermann commented 4 years ago

I see no difference in the current fix from the previous fix you've implemented. As I already said, the 'View.GONE' and 'View.VISIBLE' method does not work well for on my device, as it creates a constant blink and not just one time. It also has a strange behaviour where if going to AR when the Recipe is at the top of the tab, going back will not position the layout at the top as before but slightly scrolled down (this is a more minor and subtle issue). The main problem with this is that it happens even if I already have the camera permissions, for every cocktail. But on the other side of things, the app and tab transitions seems to run much faster - and since I don't have an idea how to actually fix this bug - I guess we could keep it this way.

@enavhasson Do you experience some kind of lag when moving from AR to Recipe? Like a black screen that shows for half a second before loading the recipe?