zokipirlo / HapiBrew-Android

Beer making app with step guidance and calculators to help you with your brewing.
http://www.hapibrew.beer/
Mozilla Public License 2.0
9 stars 0 forks source link

Not respecting mash infuse temp #2

Open deanoemcke opened 7 years ago

deanoemcke commented 7 years ago

Hey. Nice app! Just getting started with it so my question may be a bit premature. Disclaimer: I am not using a grainfather. Is this app going to be useful at all?

I have a recipe that states a mash infuse temp of 78C (target temp 67C). The first thing the app tells me to do on brewday is to prepare water for 67*C. Shouldn't thins be the strike temp, not the target temp?

zokipirlo commented 7 years ago

Hi! Thank you!

It can be useful for step timings, notifications and tools, but mash and sparge volumes calculation are adjusted for Grainfather. I'm planning to include additional equipments and also support for custom equipments (I'm already parsing that from beerxml but it's not in use yet).

If you look at the Mash Step specification you can see that there is no infusion temperature record, so I can't take it. And for the Grainfather is not important because of a wort recirculation. I guess it need to be calculated somehow. I will think about that, will be supported in future versions.

Edit: Oh, I see now in Mash step extensions. Commented a little too fast. Yes, will add parsing for that and display that. Thank you for reporting this issue.

deanoemcke commented 7 years ago

Your link was broken but I assume you meant this one: http://www.beerxml.com/mash.xml In it, I can see an infuse temp?

MASH_STEPS>
  <MASH_STEP>
    <NAME>Saccharification</NAME>
    <VERSION>1</VERSION>
    <TYPE>Infusion</TYPE>
    <INFUSE_AMOUNT>11.829480</INFUSE_AMOUNT>
    <STEP_TIME>75</STEP_TIME>
    <STEP_TEMP>65.55555600</STEP_TEMP>
    <RAMP_TIME>15</RAMP_TIME>
    <END_TEMP>65.55555600</END_TEMP>
    <DESCRIPTION>Add 12.50 qt of water at 161.4 F</DESCRIPTION>
    <WATER_GRAIN_RATIO>1.25</WATER_GRAIN_RATIO>
    <DECOCTION_AMT>0.00 qt</DECOCTION_AMT>
    <INFUSE_TEMP>161.4 F</INFUSE_TEMP>
    <DISPLAY_STEP_TEMP>DISPLAY_STEP_TEMP</DISPLAY_STEP_TEMP>
    <DISPLAY_INFUSE_AMT>12.50 qt</DISPLAY_INFUSE_AMT>
  </MASH_STEP>
  <MASH_STEP>
    <NAME>Mash Out</NAME>
    <VERSION>1</VERSION>
    <TYPE>Temperature</TYPE>
    <INFUSE_AMOUNT>0.000000</INFUSE_AMOUNT>
    <STEP_TIME>10</STEP_TIME>
    <STEP_TEMP>75.55555600</STEP_TEMP>
    <RAMP_TIME>10</RAMP_TIME>
    <END_TEMP>75.55555600</END_TEMP>
    <DESCRIPTION>Heat to 168.0 F over 10 min</DESCRIPTION>
    <WATER_GRAIN_RATIO>1.25</WATER_GRAIN_RATIO>
    <DECOCTION_AMT>0.00 qt</DECOCTION_AMT>
    <INFUSE_TEMP>182.0 F</INFUSE_TEMP>
    <DISPLAY_STEP_TEMP>DISPLAY_STEP_TEMP</DISPLAY_STEP_TEMP>
    <DISPLAY_INFUSE_AMT>0.00 qt</DISPLAY_INFUSE_AMT>
  </MASH_STEP>
</MASH_STEPS>

Edit: I also commented too fast. Will leave here for reference.

deanoemcke commented 7 years ago

Also, I'd love to see custom equipment. I imagine that this would be the more common use-case for your app? I guess you're still in the personal project phase. I guess I'll just have to go and buy a grainfather :D

zokipirlo commented 7 years ago

Have fixed link now. It's htm not html :)

INFUSE_TEMP is an Mash extension. I will add support for it.

Yes, came out as a personal project, because I was frustrated with the original Grainfather app. I have in plan a lot of things, but as an after work project it's hard to do everything at once :) Doing my best, support for custom equipment is in plan. Also cloud sync and recipe builder.

zokipirlo commented 7 years ago

Does make infuse_tempany sense after first mash step?

deanoemcke commented 7 years ago

I think so. Below is an example from beer_xml -> mash.xml. It has mash-in and mash-out steps. Both require changing of the temperature and the infuse temp seems to be the required temperature of the new water to achieve the desired temp (infuse temp seems to be another work for strike temp). So in the example below, to achieve the desired mash-in temp of 70 C it says to infuse 11.8L at 170.5 F (not sure why they mix celsius and fahrenheit here). And then to mash out at the desired 75.5 C you need to infuse an extra 4.7L at 196.6 F into the existing mash (i guess assuming the existing mash is still at 70 C). Does that sound right?

<MASH_STEPS>
    <MASH_STEP>
        <NAME>Mash In</NAME>
        <VERSION>1</VERSION>
        <TYPE>Infusion</TYPE>
        <INFUSE_AMOUNT>11.829480</INFUSE_AMOUNT>
        <STEP_TIME>45</STEP_TIME>
        <STEP_TEMP>70.00000000</STEP_TEMP>
        <RAMP_TIME>2</RAMP_TIME>
        <END_TEMP>70.00000000</END_TEMP>
        <DESCRIPTION>Add 12.50 qt of water at 170.5 F</DESCRIPTION>
        <WATER_GRAIN_RATIO>1.25</WATER_GRAIN_RATIO>
        <DECOCTION_AMT>0.00 qt</DECOCTION_AMT>
        <INFUSE_TEMP>170.5 F</INFUSE_TEMP>
        <DISPLAY_STEP_TEMP>DISPLAY_STEP_TEMP</DISPLAY_STEP_TEMP>
        <DISPLAY_INFUSE_AMT>12.50 qt</DISPLAY_INFUSE_AMT>
    </MASH_STEP>
    <MASH_STEP>
        <NAME>Mash Out</NAME>
        <VERSION>1</VERSION>
        <TYPE>Infusion</TYPE>
        <INFUSE_AMOUNT>4.731792</INFUSE_AMOUNT>
        <STEP_TIME>10</STEP_TIME>
        <STEP_TEMP>75.55555600</STEP_TEMP>
        <RAMP_TIME>2</RAMP_TIME>
        <END_TEMP>75.55555600</END_TEMP>
        <DESCRIPTION>Add 5.00 qt of water at 196.6 F</DESCRIPTION>
        <WATER_GRAIN_RATIO>1.75</WATER_GRAIN_RATIO>
        <DECOCTION_AMT>0.00 qt</DECOCTION_AMT>
        <INFUSE_TEMP>196.6 F</INFUSE_TEMP>
        <DISPLAY_STEP_TEMP>DISPLAY_STEP_TEMP</DISPLAY_STEP_TEMP>
        <DISPLAY_INFUSE_AMT>5.00 qt</DISPLAY_INFUSE_AMT>
    </MASH_STEP>
</MASH_STEPS>
zokipirlo commented 7 years ago

Oh, I see. Will need to change steps a little for that.