search

zokradonh / kopano-docker

Unofficial Kopano Docker images for all Kopano services.
MIT License
59 stars 36 forks source link

z-push default configuration mismatch #411

Closed engelant closed 4 years ago

engelant commented 4 years ago

With the default docker configuration there is an inconsistency of the config between autodiscover.conf.php and z-push.conf.php. Assuming the default OOBE behaviour is a single domain configuration, the file z-push.conf.php needs this line changed define('USE_FULLEMAIL_FOR_LOGIN', false); which can again be accomplished by adding this to kopano_zpush.env KCCONF_ZPUSH_USE_FULLEMAIL_FOR_LOGIN=false

However, I suppose it would be best to make it default for new installations by adding it to the defaults of the setup routine, so it won't break existing installations. This misaligned defaults seems to come directly from z-push repo.

fbartels commented 4 years ago

The reasoning behind having this value set to true can be found in:

engelant commented 4 years ago

But wouldn't that mean this should then also be set true?

fbartels commented 4 years ago

I think it could. Has been a while since I last set it up.

engelant commented 4 years ago

Let me throw in another point of view: With the default installation using OpenLDAP and the test users, one creates a domain with an self selected domain/suffix. After the setup one can login to kopano via /webapp with only the username e.g. user1 instead of the full username. In terms of consistency I would argue, that same should go for z-push, at least for the default setup. Again, pointing out that the "default installation" seems to represent a single domain installation. Or to put it differently: why does the default login format between z-push and webapp differ?

fbartels commented 4 years ago

In terms of consistency I would argue, that same should go for z-push, at least for the default setup.

Yes, but that already works with the default configuration. But I agree that just based on the name of the configuration option that may not be intuitive.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days