zokugun / vscode-sync-settings

Easily synchronize your settings
MIT License
146 stars 12 forks source link

Feature: Commit settings #35

Open stdedos opened 2 years ago

stdedos commented 2 years ago

I would like to have an option to "Commit local settings".

Use Case: I have a remote repository setup, and it is unavailable "at the moment". Instead of configuration being "of commit-size" and "committed", I have to wait until the remote repository becomes available

While I can see "Difference between committed and current settings", I'd like to see that "on the git-diff window" (then, I could at least manually do git commit)

daiyam commented 2 years ago

You could use a local git and manually commit to the remote, no?

stdedos commented 2 years ago

"Probably". Which begs the question "why are those two separate flows?"

repository:
  type: git

can be one thing. Both kinds support committing / use commit as their operation.

path: controls where the repo "exists physically on the disk". If unset, zokugun/vscode-sync-settings/ internalizes the repo (as in the url: flow) If there's an url: key set, also Download/Upload actions are activated.

Is there some fault in my logic?

daiyam commented 2 years ago

The no path, no url is a bit useless since it can't be synced by the user* or to a remote.

The remote git is built on top of the local git (in temp directory) with additional pull/push actions.

*It's possible but the directory is inside the storage directory of VSCode. It's a bit cumbersome to access it.