#17 - implement Wallet.File.ledger()

[t-izbassar]

Fix for #17. Implemented ledger() method. Updated relevant test case.

[0crat]

Job #30 is now in scope, role is REV

[0crat]

Job #30 is already in scope

[0crat]

This pull request #30 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

[codecov-io]

Codecov Report

Merging #30 into master will increase coverage by 0.26%. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #30      +/-   ##
=========================================
+ Coverage     94.73%   95%   +0.26%     
  Complexity       17    17              
=========================================
  Files             3     3              
  Lines            38    40       +2     
  Branches          1     1              
=========================================
+ Hits             36    38       +2     
  Misses            2     2

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/io/zold/api/Wallet.java	100% <100%> (ø)	0 <0> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1405fe3...f524275. Read the comment docs.

[t-izbassar]

@carlosmiranda updated.

[t-izbassar]

@llorllale merge?

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale Done! FYI, the full log is here (took me 11min)

[0crat]

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

Job gh:zold-io/java-api#30 is not assigned, can't get performer

[0crat]

The job #30 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[ypshenychka]

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

Two out of four found issues are cosmetic. Please confirm that you'll try to find at least three major problems while future reviews.

[carlosmiranda]

@ypshenychka confirmed

[ypshenychka]

@carlosmiranda thanks

[ypshenychka]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +15 point(s) just awarded to @carlosmiranda/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

[g4s8]

@0crat status

[0crat]

@0crat status (here)

@g4s8 This is what I know about this job in CAZUREFND, as in §32:

• The job #30 is not in scope
• Job footprint (restricted area)