Implement Wallet.pay

[victornoel]

This is for #29:

• implement Wallet.pay by writing the transaction at the end of the wallet
• introduced a @todo to implement a computed transaction (CpTransaction)

Note that I used eo-envelope to generate an envelope instead of writing it. @yegor256 said in the past he would agree to use this library in its project and I have been using it for a month or two in real world projects without any problems. I would expect @llorllale to validate this choice as ARC.

[0crat]

Job #46 is now in scope, role is REV

[0crat]

Job #46 is already in scope

[0crat]

This pull request #46 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

[codecov-io]

Codecov Report

Merging #46 into master will increase coverage by 1.94%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     92.42%   94.36%   +1.94%     
- Complexity       30       32       +2     
============================================
  Files             4        5       +1     
  Lines            66       71       +5     
  Branches          4        4              
============================================
+ Hits             61       67       +6     
+ Misses            5        4       -1

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/io/zold/api/Wallet.java	93.33% <100%> (+1.66%)	0 <0> (ø)	:arrow_down:
src/main/java/io/zold/api/CpTransaction.java	100% <100%> (ø)	1 <1> (?)
src/main/java/io/zold/api/RtTransaction.java	100% <0%> (+3.57%)	18% <0%> (+1%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f5d093...08f5b61. Read the comment docs.

[victornoel]

@carlosmiranda I have updated the PR to follow your recommendations.

[carlosmiranda]

@llorllale ping

[carlosmiranda]

@llorllale ping

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale @victornoel Oops, I failed. You can see the full log here (spent 11min)

My version is 0.20.3
Ruby version is 2.3.3 at x86_64-linux
Reading /home/r/repo
Excluding target/**/*
Excluding src/site/resources/**/*
34 file(s) found, 748 excluded
Reading .0pdd.yml...
Reading .travis.yml...
Reading LICENSE.txt...
Reading .pdd...
Reading .rultor.yml...
Reading README.md...
Reading .gitignore...
Reading src/test/resources/walletsIn/1.z...
Reading src/test/resources/walletsIn/3.z...
Reading src/test/resources/walletsIn/5.z...
Reading src/test/resources/walletsIn/4.z...
Reading src/test/resources/walletsIn/2.z...
Reading src/test/resources/walletsIn/6...
Reading src/test/resources/wallets/12345678abcdef...
Reading src/test/resources/wallets/invalid_id...
Reading src/test/java/io/zold/api/WalletsInTest.java...
Reading src/test/java/io/zold/api/NetworkTest.java...
Puzzle 5-38f68f69 30/DEV at src/test/java/io/zold/api/NetworkTest.java
Reading src/test/java/io/zold/api/CpTransactionTest.java...
Reading src/test/java/io/zold/api/package-info.java...
Reading src/test/java/io/zold/api/WalletTest.java...
Puzzle 33-65714492 30/DEV at src/test/java/io/zold/api/WalletTest.java
Reading src/test/java/io/zold/api/RtTransactionTest.java...
Reading src/main/java/io/zold/api/Score.java...
Reading src/main/java/io/zold/api/WalletsIn.java...
Puzzle 4-968ad704 30/DEV at src/main/java/io/zold/api/WalletsIn.java
Reading src/main/java/io/zold/api/RtNetwork.java...
Puzzle 5-fd3c6d54 30/DEV at src/main/java/io/zold/api/RtNetwork.java
Puzzle 5-c56bb757 30/DEV at src/main/java/io/zold/api/RtNetwork.java
Puzzle 5-dec07794 30/DEV at src/main/java/io/zold/api/RtNetwork.java
Reading src/main/java/io/zold/api/Wallets.java...
Reading src/main/java/io/zold/api/CpTransaction.java...
Puzzle 29-73894838 30/DEV at src/main/java/io/zold/api/CpTransaction.java
Reading src/main/java/io/zold/api/Network.java...
Reading src/main/java/io/zold/api/Remote.java...
Reading src/main/java/io/zold/api/package-info.java...
Reading src/main/java/io/zold/api/Transaction.java...
Reading src/main/java/io/zold/api/Wallet.java...
Puzzle 6-af7c6ffd 30/DEV at src/main/java/io/zold/api/Wallet.java
Reading src/main/java/io/zold/api/RtTransaction.java...
Puzzle 15-b88242e3 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-4f67a35d 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-1e017e66 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-a01f2b41 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-957c2199 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-ad2b4fa5 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Puzzle 15-0d2d728d 30/DEV at src/main/java/io/zold/api/RtTransaction.java
Reading pom.xml...
Reading .gitattributes...
\u001b[31mERROR\u001b[0m: Puzzle src/main/java/io/zold/api/CpTransaction.java:30-31 has a very short description of just 18 words while a minimum of 20 is required
\u001b[31mERROR\u001b[0m: 1 errors, see log above. If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1
container 833aa2b4a707525e024c08d57e55294a338d063d5cddc731afdacc00af0ae617 is dead
Wed Jul 25 12:22:10 CEST 2018

[victornoel]

@llorllale I've improved the @todo description

[carlosmiranda]

@llorllale ping

[0crat]

@carlosmiranda/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale Done! FYI, the full log is here (took me 13min)

[0crat]

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #46 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[ypshenychka]

@0crat quality good

[0crat]

Order was finished, quality is "good": +20 point(s) just awarded to @carlosmiranda/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z