zold-io / zold.github.io

Zold website and JavaScript assets
https://www.zold.io
16 stars 4 forks source link

fixes proposed by yegor256 #52

Closed blackout314 closed 6 years ago

blackout314 commented 6 years ago

task #25

0crat commented 6 years ago

@yegor256/z please, pay attention to this pull request

0crat commented 6 years ago

Job #52 is now in scope, role is REV

0crat commented 6 years ago

@yegor256/z everybody who has role REV is banned at #52; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 commented 6 years ago

@blackout314 I don't think zoom:4 will solve the problem with the map

blackout314 commented 6 years ago

@yegor256 ok i will fix, is a map configuration issue

blackout314 commented 6 years ago

@yegor256 no example for avoid gray border https://developers.google.com/maps/documentation/javascript/examples/control-default

all google maps in documentation show gray borders


i've made a workaround, after surpassing border, i set 0,0 on map

yegor256 commented 6 years ago

@blackout314 see above. Also, when you copy some code from SO, it's better to place a link in the code (a comment) explaining where the code is coming from. This will help understand your intention, in the future.

blackout314 commented 6 years ago

@yegor256 ok boss, is one of many try because isnt supported by google maps v3, is a workaround

yegor256 commented 6 years ago

@blackout314 see above

blackout314 commented 6 years ago

@yegor256 code cleaned

yegor256 commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

0crat commented 6 years ago

Job gh:zold-io/zold.github.io#52 is not assigned, can't get performer

0crat commented 6 years ago

The job #52 is now out of scope