zold-io / zold

An Experimental Non-Blockchain Cryptocurrency for Fast Micro Payments
https://www.zold.io
MIT License
194 stars 53 forks source link

when Referer is present the server returns 403 #745

Open yegor256 opened 5 years ago

yegor256 commented 5 years ago

When Referer HTTP header is present in the request, the response is always 403. Why? Let's create a unit test to reproduce the problem, and fix it.

golyalpha commented 5 years ago

@yegor256 Note that it's not whenever Referer header is present, but whenever it is present and it doesn't match with whatever's in the Host header. At least that is my assumption, since I can't reliably check because of HTTPS throwing a certificate error when I change the Host, and the alternative to it checking with the Host header is having the proper domain in the code, or in the environment variables.

0crat commented 5 years ago

Job #745 is now in scope, role is DEV

yegor256 commented 5 years ago

@0crat assign @golyalpha

yegor256 commented 5 years ago

@golyalpha I would suggest to create a new test method in test_front.rb and try to reproduce the issue. Then find a way to fix it.

golyalpha commented 5 years ago

@yegor256 Thanks for the suggestion, will do.

0crat commented 5 years ago

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

0crat commented 5 years ago

@0crat assign @golyalpha (here)

@yegor256 The job #745 assigned to @golyalpha/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

0crat commented 5 years ago

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

0crat commented 5 years ago

@golyalpha/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

golyalpha commented 5 years ago

@yegor256 I can't seem to find the endpoint for /rate.json I know this is likely an issue relating to all endpoints, but, how would you like me to proceed?

golyalpha commented 5 years ago

@0crat waiting on response

0crat commented 5 years ago

@0crat waiting on response (here)

@golyalpha The impediment for #745 was registered successfully by @golyalpha/z