Open lastk opened 5 years ago
@lastk this is nice, but it has to be used by all other classes in the project.
@yegor256 I found some references for just wallets
and copies
( missing remotes ) in some constructors like here: https://github.com/zold-io/zold/blob/master/lib/zold/commands/diff.rb#L42
in this case, would still be ok passing an home
object with an empty remotes
? or better leave it as it is.
Merging #746 into master will decrease coverage by
<.01%
. The diff coverage is24.32%
.
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 33.88% 33.88% -0.01%
==========================================
Files 76 77 +1
Lines 3816 3840 +24
==========================================
+ Hits 1293 1301 +8
- Misses 2523 2539 +16
Impacted Files | Coverage Δ | |
---|---|---|
lib/zold/node/pipeline.rb | 32.72% <0%> (ø) |
:arrow_up: |
lib/zold/node/spread_entrance.rb | 33.92% <0%> (ø) |
:arrow_up: |
lib/zold/remotes.rb | 35.71% <100%> (ø) |
:arrow_up: |
lib/zold/commands/node.rb | 17.96% <11.11%> (-0.07%) |
:arrow_down: |
lib/zold/commands/merge.rb | 19.6% <14.28%> (-0.4%) |
:arrow_down: |
lib/zold/hungry_wallets.rb | 26.53% <14.28%> (-0.56%) |
:arrow_down: |
lib/zold/commands/pull.rb | 55.55% <14.28%> (-3.27%) |
:arrow_down: |
lib/zold/commands/routines/reconcile.rb | 34.37% <16.66%> (-1.11%) |
:arrow_down: |
lib/zold/commands/invoice.rb | 36.11% <16.66%> (-1.04%) |
:arrow_down: |
lib/zold/commands/fetch.rb | 28.22% <20%> (-0.23%) |
:arrow_down: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 27f64d4...e1517be. Read the comment docs.
This pull request #746 is assigned to @v-kolesnikov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
@yegor256/z please, pay attention to this pull request