Stop using require_relative

[golyalpha]

Refactored the tests to stop using require_relative to import files from lib.

Issue: #363

[0crat]

@yegor256/z please, pay attention to this pull request

[0crat]

Job #747 is now in scope, role is REV

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[golyalpha]

@0crat status

[0crat]

@0crat status (here)

@golyalpha This is what I know about this job in CAZPZR9FS, as in §32:

• The job #747 is in scope for 11hr
• The role is REV
• The job is not assigned to anyone
• The budget is not set yet
• These users are banned and won't be assigned:
  • @golyalpha/z: This user reported the ticket
• Job footprint (restricted area)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #747; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@golyalpha @yegor256 Oops, I failed. You can see the full log here (spent 11min)

+ for p in '"$@"'
++ curl --silent 'http://127.0.0.1:46164/pid?halt=test'
+ pid=28080
+ [[ 28080 =~ ^[0-9]+$ ]]
+ i=0
+ kill -0 28080
+ (( i++ ))
+ sleep 0
+ (( i==30 ))
+ echo 'Still waiting for process 28080 to die, attempt no.1'
Still waiting for process 28080 to die, attempt no.1
+ sleep 2
+ kill -0 28080
+ (( i++ ))
+ (( i==30 ))
+ echo 'Still waiting for process 28080 to die, attempt no.2'
Still waiting for process 28080 to die, attempt no.2
+ sleep 2
+ kill -0 28080
+ (( i++ ))
+ (( i==30 ))
+ echo 'Still waiting for process 28080 to die, attempt no.3'
Still waiting for process 28080 to die, attempt no.3
+ sleep 2
+ kill -0 28080
+ (( i++ ))
+ (( i==30 ))
+ echo 'Still waiting for process 28080 to die, attempt no.4'
Still waiting for process 28080 to die, attempt no.4
+ sleep 2
+ kill -0 28080
spread-wallets.sh: line 55: kill: (28080) - No such process
+ echo 'Process 28080 is dead!'
Process 28080 is dead!
+ echo 'Node at TCP port 46164 stopped!'
Node at TCP port 46164 stopped!
.
Expected: 0
  Actual: 1792
\u001b[0m

bin/rails test home/r/repo/test/test_zold.rb:38

Interrupted. Exiting...

Finished in 476.337432s, 0.4430 runs/s, 1.2365 assertions/s.
211 runs, 589 assertions, 1 failures, 0 errors, 7 skips

You have skipped tests. Run with --verbose for details.
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test" -I"/home/r/.ruby/gems/rake-12.3.1/lib" "/home/r/.ruby/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/commands/routines/test_audit.rb" "test/commands/routines/test_gc.rb" "test/commands/routines/test_reconcile.rb" "test/commands/routines/test_reconnect.rb" "test/commands/routines/test_retire.rb" "test/commands/test_alias.rb" "test/commands/test_calculate.rb" "test/commands/test_clean.rb" "test/commands/test_create.rb" "test/commands/test_diff.rb" "test/commands/test_fetch.rb" "test/commands/test_invoice.rb" "test/commands/test_list.rb" "test/commands/test_merge.rb" "test/commands/test_node.rb" "test/commands/test_pay.rb" "test/commands/test_propagate.rb" "test/commands/test_pull.rb" "test/commands/test_push.rb" "test/commands/test_remote.rb" "test/commands/test_remove.rb" "test/commands/test_show.rb" "test/commands/test_taxes.rb" "test/node/test_async_entrance.rb" "test/node/test_entrance.rb" "test/node/test_farm.rb" "test/node/test_farmers.rb" "test/node/test_front.rb" "test/node/test_nodup_entrance.rb" "test/node/test_nospam_entrance.rb" "test/node/test_safe_entrance.rb" "test/node/test_spread_entrance.rb" "test/node/test_sync_entrance.rb" "test/node/test_trace.rb" "test/test__helper.rb" "test/test_age.rb" "test/test_amount.rb" "test/test_cached_wallets.rb" "test/test_copies.rb" "test/test_dir_items.rb" "test/test_gem.rb" "test/test_hands.rb" "test/test_hexnum.rb" "test/test_http.rb" "test/test_hungry_wallets.rb" "test/test_id.rb" "test/test_json_page.rb" "test/test_key.rb" "test/test_log.rb" "test/test_metronome.rb" "test/test_patch.rb" "test/test_prefixes.rb" "test/test_remotes.rb" "test/test_signature.rb" "test/test_size.rb" "test/test_sync_wallets.rb" "test/test_tax.rb" "test/test_thread_pool.rb" "test/test_tree_wallets.rb" "test/test_txn.rb" "test/test_upgrades.rb" "test/test_verbose_thread.rb" "test/test_version.rb" "test/test_wallet.rb" "test/test_wallets.rb" "test/test_zold.rb" "test/upgrades/test_delete_banned_wallets.rb" "test/upgrades/test_protocol_up.rb" ]
/home/r/.ruby/gems/rake-12.3.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.6.0/bin/ruby_executable_hooks:24:in `eval'
/usr/local/rvm/gems/ruby-2.6.0/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container 8d35656da6affb9254e2da27a0bdbc0fdc6109ab191c150eeac5721a1265b426 is dead
Wed May  8 15:01:54 CEST 2019

[yegor256]

@golyalpha there are some problems

[golyalpha]

@yegor256 Are there any tests that run on Rultor but nowhere else?

I'm asking because locally and on travis all tests pass, but on Rultor one fails. And from what I can see, both travis and rultor skip 7 tests.

[0crat]

This pull request #747 is assigned to @samihibrahim/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job