v-kolesnikov commented 5 years ago

Issue #610

0crat commented 5 years ago

Job #755 is now in scope, role is REV

yegor256 commented 5 years ago

@v-kolesnikov what happened with the description of the PR? Read this https://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html

Also, where are the tests? How do you know it works?

codecov-io commented 5 years ago

Codecov Report

Merging #755 into master will increase coverage by <.01%. The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   33.88%   33.89%   +<.01%     
==========================================
  Files          76       76              
  Lines        3816     3824       +8     
==========================================
+ Hits         1293     1296       +3     
- Misses       2523     2528       +5

Impacted Files	Coverage Δ
lib/zold/commands/node.rb	`18.54% <27.27%> (+0.51%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e0f693...9b76380. Read the comment docs.

0crat commented 2 years ago

This pull request #755 is assigned to @anaumov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

zold-io / zold

#610 Add `zold node --nohup-log-rotate` option #755

Codecov Report