New setting that allows not to override the selected text with fetched link

zolrath / obsidian-auto-link-title

Automatically fetch the titles of pasted links

MIT License

443 stars 62 forks source link

New setting that allows not to override the selected text with fetched link #109

Closed neoromantic closed 5 months ago

neoromantic commented 7 months ago

Based on https://github.com/zolrath/obsidian-auto-link-title/issues/50

Very simple PR that:

adds a new setting
in case if it's enabled, respects existing text selection as title

neoromantic commented 6 months ago

@zolrath any chance on merging this?

math-feng commented 5 months ago

[[Real_Analysis-Folland -.pdf#page=73&selection=2,0,5,3&color=yellow]]

Links formatted like this won't work, can you fix this please, thank you very much!

zolrath commented 5 months ago

Hi, I like this idea, sorry for the delay! I'm fairly certain the "Replace Selection" option was intended to be this behavior but was never actually implemented!

Let's merge these options and have the behavior use your logic instead.

Thanks for the PR!

reagle commented 4 months ago

FYI: I've long used both obsidian-auto-link-title and obsidian-url-into-selection and they worked well together:

if I was pasting a URL with nothing selected (into an empty caret/space) auto-link title would create a title and link.
if I was pasting int selected text, obsidian-url-into-selection would make it hypertextual.

With this update, they are both doing their thing at the same time, leading to a redundant link. However, if I enable Preserve selection as title and remove obsidian-url-into-selection, things work well again.