search

zoltan-dulac / css3FontConverter

A shell script that can use other command line tools to produce @font-face compatible fonts in all browsers. Works under Windows (using Cygwin), Mac OS X and Linux
http://www.useragentman.com/blog/2011/02/20/converting-font-face-fonts-quickly-in-any-os/
390 stars 62 forks source link

Remove Java dependency from main executable #17

Open shehi opened 7 years ago

shehi commented 7 years ago

Hi @zoltan-dulac ,

Checking some forks made from this package, I noticed @raldred has made some significant improvements to the codebase at https://github.com/raldred/css3FontConverter. Could you please view his 3 additional commits in his fork and bring them in, to this original package?

raldred commented 7 years ago

Beware my changes are 3 years old and Mac OSX specific

shehi commented 6 years ago

@zoltan-dulac , can you look at this one please? :)

zoltan-dulac commented 6 years ago

Hello.

I am more than willing to look into @raldred's changes (as well as the others). His changes are OSX specific and it will probably require a refactor to make sure everything works with other platforms.

I'll update this issue when I have looked into this. Thanks for the reminder. :-)

zoltan-dulac commented 6 years ago

@shehi : I have not added the changes requested since they are pretty specific to OSX (and since the code has a lot more features since his changes were made).

If you would like to add the OSX dfont support, I suggest extracting the font files from the dfont archive using fondu (which is what his fork uses). fondu can be installed using homebrew or macports, but if you want to compile yourself, I have set up a clone of the original repo (with some changes that will allow it compile under Cygwin for Windows) at:

https://github.com/zoltan-dulac/fondu

shehi commented 6 years ago

@zoltan-dulac , can we at least drop Java dependency from the main .sh file please? I have to install that huge platform (JVM) in my Docker because of this line: https://github.com/zoltan-dulac/css3FontConverter/blob/master/convertFonts.sh#L478 Please let's get rid of java check there - we don't really need it, do we? Should I send in a PR for this?