zom-ponks / rpcs3-gameupdater

Fetches game updates for the RPCS3 emulator
MIT License
2 stars 1 forks source link

Rename in-download files to show they are not complete #44

Closed John-Gee closed 4 years ago

John-Gee commented 4 years ago

Kind of how chrome and others do, so instead of XXX.pkg we'd do something like XXX.pkg.tmp or so till fully downloaded (and checked?).

From a CLI user, I think it's nice to be able to see which files should be complete and which should not. I think we could also use that for a few speedups in resuming the app (for instance grab won't need to retry any file that is not .tmp, and then we defer everything else to the integrity of the FS).

(Not exactly related, but same function so I'll add here: we should not checksum a file that failed to download, it's just a waste of time)

John-Gee commented 4 years ago

Done in #47

(As for the extra in parenthesis, I am ashamed, the code already handles this just fine, I should really know my own code...)