zom / Zom-Android-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-android-matrix
GNU General Public License v3.0
141 stars 65 forks source link

Incorrect response to multiple friend requests #339

Closed n8fr8 closed 7 years ago

n8fr8 commented 7 years ago

When a remote user "waiting for approval" presses the refresh button, the user is automatically approved by Android without the receiving user having control.

cstiens commented 7 years ago

Related issue and testing results on the iOS tracker: https://github.com/zom/Zom-iOS/issues/432

tiffrobo commented 7 years ago

When a user sends a new friend request to someone and the user who is "waiting for approval" presses the refresh button, they receive a notification saying "you and so-and-so are now friends". You can open a chat with the friend, but you never exchange keys and cannot chat. The 'new friend' has not accepted or refused your request.

We tested and reproduced this bug.

Devices: Moto X, Moto G Play and Samsung Galaxy S7 Build and App version: 15.3. beta 8

n8fr8 commented 7 years ago

The "refresh" button now just resubmits the friend request, without changing the local status.

cstiens commented 7 years ago

@n8fr8 This issue is fixed, but there's a related issue—when you tap on the friend invite notification, it opens a chat with that person and adds them as a contact. #360

cstiens commented 7 years ago

Looks like these are all taken care of now!