Wording of invite message mentions Chatsecure

zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!

https://github.com/zom/zom-ios-matrix

Mozilla Public License 2.0

37 stars 23 forks source link

Wording of invite message mentions Chatsecure #535

Closed cstiens closed 6 years ago

cstiens commented 6 years ago

Android ticket with more info: https://github.com/zom/Zom-Android/issues/428

cstiens commented 6 years ago

This message shouldn't be displayed at all. @N-Pex are you able to reproduce this on your iOS devices? I believe it shows up anytime you are added to a group, regardless of whether iOS or Android created it.

N-Pex commented 6 years ago

@cstiens Hm, no, I can't reproduce it?!?

N-Pex commented 6 years ago

Actually, now I could, when I logged out then in again. It's related to MAM catchups, when we get the group invites we inserted them in the message stream...

@chrisballinger PR sent. Is it possible, like we talked about, to somehow restrict the initial mam fetch in onAuthenticated to only fetch history for one-to-one chats, not groups? In this case the problem was that the "joined" flag was still false because we got the MAM stuff "too early".

cstiens commented 6 years ago

Successfully removed in build 121. :)

chrisballinger commented 6 years ago

@N-Pex There should still be code to filter out these "direct invites", but it might not be working properly with nested MAM messages