zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-ios-matrix
Mozilla Public License 2.0
37 stars 23 forks source link

UI to pass admin status if the only admin leave a group #543

Closed cstiens closed 6 years ago

kckthx commented 6 years ago

@cstiens I did this for iOS and Android group_choose-owner-android group_choose-owner-ios

N-Pex commented 6 years ago

First version will be in build 127. We still have a few things to discuss here. Transfer is only done currently when hitting "leave" in the room occupants view, not when swiping and doing "delete" in the conversations list.

Also, it seems like the leaving person is not completely "cleaned up" and detached from the group. If the "new" owner re-adds the old owner, the old owner is still marked as an "owner".

tiffrobo commented 6 years ago

Yes, @N-Pex I'm seeing what you are seeing. 1) Transfer only done when user action is 'Leave' from the roster view. 2) Owner is still showing in group member's roster after leaving. 3) Can be re-added and with owner permissions.

How it is working:

The new owner is given the 'owner permissions' (kick out, make admin, etc.)

---------(@cstiens @N-Pex Should the new 'owner' get a notification/indication they are the new owner?

Device: iPhone7, iPhone6, iPad OS: 11.2.2, 10.3.3, 10.3.2 App version: Build 127

cstiens commented 6 years ago

Also, it seems like the leaving person is not completely "cleaned up" and detached from the group. If the "new" owner re-adds the old owner, the old owner is still marked as an "owner".

I think this is okay. @N-Pex unless there's something I'm missing.

Let's do these, though.

N-Pex commented 6 years ago

Ok, fixed in 129.

tiffrobo commented 6 years ago

These are done and working:

Device: iPhone 6, iPhone 7, iPad OS: 10.3.3, 11.2.2, 10.3.2 App version: build 129