search

zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-ios-matrix
Mozilla Public License 2.0
37 stars 23 forks source link

Add in-line text when someone new is added to the group #544

Closed cstiens closed 6 years ago

cstiens commented 6 years ago

@N-Pex do/can we know when someone is added to a group versus when they join a group. I'm thinking about having text for both cases.

"Rosa invited Julie to the group." and "Julie joined the group."

cstiens commented 6 years ago

Since we only know when someone joins a group, we would show text that says— "Julie joined the group."

screenshot 2018-03-21 13 50 13

If someone joins and they are not your friend, you would get the inline prompt to add them.

screenshot 2018-03-21 13 49 46
tiffrobo commented 6 years ago

In build 127, I see the in-line text when someone who is not your friend joins the group, but I don't see when a 'friend' of yours joins/ is added to the group.

Device: iPhone 7, iPhone 6, iPad OS: 11.2.2, 10.3.3, 10.3.2 App version: build 127

cstiens commented 6 years ago

@N-Pex Can we show both? If the person is already your friend, but added to the group, we would include that inline.

tiffrobo commented 6 years ago

Who should see the in-line text? If the owner adds people to the group will they see the in-line text?

This is really buggy. I saw it appear once as a flash. Once it was there and appeared to be working and the other three times it never appeared to anyone in the group.

Looks good when it appears:) img_4827

Device: iPhone 6, iPhone 7, iPad OS: 10.3.3, 11.2.2, 10.3.2 App version: build 129

cstiens commented 6 years ago

I made a new ticket for the bug: https://github.com/zom/Zom-iOS/issues/595