search

zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-ios-matrix
Mozilla Public License 2.0
37 stars 23 forks source link

New admin permissions missing #573

Closed tiffrobo closed 6 years ago

tiffrobo commented 6 years ago

If you are in a group and are made a new admin (given permission from the group creator) some permissions are missing.

In and working: -crown (shown in all members' rosters) -change group name -add friends

Missing and not working: -tapping on members name in the roster only shows "view profile" Not shown: "make admin" and "kick out"

-Bug: When the iPad became a new admin and tapped on any profile in the group roster the app crashed, every time.

Device: iPhone 7 OS: 11.2.2

Device: iPhone 6 OS: 10.3.3

Device: iPad OS: 10.3.2

App version: 126

N-Pex commented 6 years ago

@tiffrobo The ipad crash I'll have a look at.

The other is not a bug - the new person is an ADMIN, not an OWNER, so can't do kick and "grant admin". Currently it's not clear in the UI who is owner and who is admin, they both are shown with a crown...

N-Pex commented 6 years ago

Ok, crash will be fixed in 127.

tiffrobo commented 6 years ago

@N-Pex okay! The iPad had no crashes during testing. So the new admins should be able to 'view the profile' and that is all? If so, then we can close the ticket!

Device: iPhone6, iPhone7, iPad OS: 11.2.2, 10.3.3, 10.3.2 App version: 127

cstiens commented 6 years ago

So the new admins should be able to 'view the profile' and that is all?

Yes. But, we would want to cut out the shortcut/action sheet when an admin taps on a profile, since the only option for a contact is to 'view profile'. Instead, tapping on the contact, should open their profile. @N-Pex can you make that change?

N-Pex commented 6 years ago

Yes, build 129.

tiffrobo commented 6 years ago

No more shortcut. After becoming an 'Admin' if you tap on a profile, it opens the friends' profile view.

Device: iPhone 6, iPhone 7, iPad OS: 10.3.3, 11.2.2, 10.3.2 App version: build 129