search

zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-ios-matrix
Mozilla Public License 2.0
37 stars 23 forks source link

New "Add Friends" UI #590

Closed kckthx closed 6 years ago

kckthx commented 6 years ago

add-friends_p2_v3-android

add-friends_p2_v3-android-specs

Add-Friends-Illustration.zip

kckthx commented 6 years ago

Add-Friends-Illustration.zip

n8fr8 commented 6 years ago

whatsapp:// custom URI scheme https://faq.whatsapp.com/iphone/23559013 for @tladesignz

n8fr8 commented 6 years ago

Unfortunately, the WeChat SDK requires you to be registered and approved: http://open.wechat.com/cgi-bin/newreadtemplate?t=overseas_open/docs/mobile/share/ios#share_ios

perhaps there is a fallback using a custom URI

tladesignz commented 6 years ago

@kckthx Can you or @cstiens provide the icons, too? I hope, they will be more uniform, than when I go search them on the net. :-) Please note:

tladesignz commented 6 years ago

Also: Please define, what should happen,

Should we

  1. grey out buttons
  2. hide buttons
  3. show error message after button press
  4. other?
kckthx commented 6 years ago

@tladesignz I've included pngs and svgs of the airdrop and nearby icon.

Nearby.zip Airdrop.zip

add-friends_p2_v2 2_airdrop

tladesignz commented 6 years ago

@kckthx, thanks, that's a start. I don't need a nearby button. That's not available on iOS. But I would need all other buttons. Also, I would need my questions be answered.

Can you help here, @N-Pex?

cstiens commented 6 years ago

@tladesignz Sorry for the slow response to your questions. Here you go!

WeChat support was dropped - not possible in that way without integrating the WeChat API using a registered API key.

Okay. We can leave that out.

Instead of the "nearby" symbol, we would need an "AirDrop" symbol.

Yes. Kaci has provided airdrop. You can ignore the nearby. We've added that to the Android ticket.

According to iOS interface guidelines, the "share" button should look a little bit differently, than three dots ("..."). See https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/system-icons/ (search "share" on that page)

Yeah. We're breaking the rules again here. Please use the 3 dots to indicate that there are more options.

Also: Please define, what should happen, when there's no WhatsApp

Don't show it. Only show iMessage and the 3 dots.

when we can't use the camera for QR code scanning (could be denied or in other ways unavailable)

If the user has denied camera access, we should still show scanning as an option, and if tapped, we should ask again to allow access to the camera. We've had cases in testing where the user accidentally denies the request to use the camera, but wants to scan. So, we want to give them (and continue to give them) second chances.

If for some reason, there is no camera available at all, then we can hide the scan option. In what cases, will there not be a camera available at all?

when there is no possibility to send SMS/iMessage. (can happen theoretically, at least in the Simulator, probably when iMessage is disabled and there is no SIM card available.)

Don't show it. Only show the 3 dots.

kckthx commented 6 years ago

Add-Friends-From.zip @tladesignz Sorry I misunderstood what icons you were needing this zip folder has the WhatsApp, iMessage, QR Code and More

tladesignz commented 6 years ago

@N-Pex: What's the best way to read the user's Jabber ID?

N-Pex commented 6 years ago

@tladesignz In ZomNewBuddyViewController you can just access (self.account as? OTRXMPPAccount)?.username

tladesignz commented 6 years ago

@N-Pex: D'oh! Thanks! I'll spare the cast, though. username is a OTRAccount property.

tiffrobo commented 6 years ago

The new UI looks and functions great! Thank you for all the work.

@tladesignz There are two things:

1) The bar at the top just needs the back arrow. Not the label with it

2) The new 'add friends' screen on the iPhone6, you must scroll to see everything. It is not the case for the iPhone 7

Device: iPhone 6, iPhone 7 OS: 10.3.3, 11.2.2 App version: build 130

tiffrobo commented 6 years ago

@tladesignz This screenshot pertains to #1. from the above comment. When you tap + (add freinds), the bar at the top has the back arrow and label. We just need the back button arrow.

img_e49afdcbb823-1

tiffrobo commented 6 years ago

@tladesignz I'm closing this ticket. A new ticket with the specific UI enhancements needed for the 'Add Friends' view are on ticket #607 .