Interim update to contact's profile view

zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!

https://github.com/zom/zom-ios-matrix

Mozilla Public License 2.0

37 stars 23 forks source link

Interim update to contact's profile view #597

Closed cstiens closed 6 years ago

cstiens commented 6 years ago

@N-Pex, @tiffrobo and I went over this last week. She can provide details. 👍

[ ] Remove 'Show More'
[ ] Remove 'Verify'
[ ] Remove 'Refresh session' if we aren't using OTR
[ ] Add 'Start chat' to every profile view
[ ] Add the number to zom codes (ex: View 2 Zom Codes or View 1 Zom Code)

tiffrobo commented 6 years ago

@N-Pex From the call today, we can make these changes to the profile view:

[x] Remove 'Show More' (Just show the last fetched key with QR code)
[x] Remove 'Verify Conact'
[x] Add 'Start chat' to every profile view
[x] Add the number to zom codes (ex: View 2 Zom Codes or View 1 Zom Code)

I guess we will keep 'refresh session' since we are using OTR keys

img_b31e94d78015-1

tiffrobo commented 6 years ago

So I see either 'start chat' or 'refresh session'. Not both. I think 'start chat' is on all profiles unless you have no OMEMO key for the contact.

Everything else in!

Device: iPhone 7 OS: 11.2.2 Build: App version 130

tiffrobo commented 6 years ago

@N-Pex We want to show all three options on profile views, all the time. Thanks!

Start Chat
Refresh Session
View (number) Zom Code(s)

tiffrobo commented 6 years ago

@N-Pex I think this one slipped by. Per the last comment 20days ago. We wanted to show all three options on profile views, all the time. I'm not seeing 'Refresh Session' I do see the other two on all profile views though.

Start Chat
Refresh Session
View (number) Zom Code(s)

Device: iPhone 7, iPad OS: 11.2.2, 10.3.2 App version: build 131

tiffrobo commented 6 years ago

@n8fr8 @chrisballinger We should have discussed this today, sorry. Can we remove 'Refresh Session' from the profile view? I know it only deals with OTR and currently only shows up sometimes. We are deciding to either add it to all profile views or remove it entirely.

N-Pex commented 6 years ago

@tiffrobo Unsure what the latest word on this is? Currently the logic seems to be:

If we entered profile view via a group chat - show "Start chat"
Else, if we entered via the chat view (message view controller) - show "Refresh"
Else (if we entered via selecting a friend from the friends list) - show "Start chat"

tiffrobo commented 6 years ago

@N-Pex The final word is that we need to keep "refresh session" around. Originally we wanted "refresh session" to be added to every profile view. I think it makes more sense what you've listed above. Because the user sees a different action which only seems to be associated with the need to reconnect (refresh) with OTR. What do you think?

tiffrobo commented 6 years ago

@N-Pex We are getting rid of "refresh session".

N-Pex commented 6 years ago

Ok, fixed in 134.

tiffrobo commented 6 years ago

Not seeing "refresh session" in build 135. Everything else in the profile view is in.

Device: iPhone 7, iPhone 6 OS: 11.2.2, 10.3.3 Build: 135