zom / Zom-iOS-XMPP

THIS PROJECT IS NOW CLOSED. WE HAVE MOVED TO A NEW ZOM 2.0 MATRIX CORE. FOLLOW THE LINK!
https://github.com/zom/zom-ios-matrix
Mozilla Public License 2.0
37 stars 23 forks source link

Disable the user interface notification for bad server certification #615

Open tiffrobo opened 6 years ago

tiffrobo commented 6 years ago

img_4969 2

@N-Pex Device: iPhone8 OS: 11.3.1 App version: release build 130

n8fr8 commented 6 years ago

This is also happening to Rosa. Any progress?

n8fr8 commented 6 years ago

@abeluck any thoughts on the server side of this possibly?

N-Pex commented 6 years ago

Yes, I am pretty sure I've fixed it (a new UUID was used every time, so instead of "reusing" the notification a new one was created). I just need to be sure that the fix is not affecting things to the other extreme, i.e. showing too few notifications because they are lumped together. Will try to do a new build soon, probably tomorrow.

n8fr8 commented 6 years ago

Can you tell me more about when it is triggered? Is it generated by a connection to the push.zom.im server or the home.zom.im?

Let's talk on the scrum today.

n8fr8 commented 6 years ago

(oops tomorrow!)

N-Pex commented 6 years ago

@n8fr8 I haven't actually tried to chase the cause, I've only fixed the symptom (by faking a connection problem in the code, so that it tries to show a new notification when trying to reconnect). I've not seen this, but that's probably because I don't test on the home.zom.im server. I can give that a go tomorrow as well.

tiffrobo commented 6 years ago

Let's keep an eye out for this. @N-Pex Fixed the multiple push notifications and user should only see one, but we need to figure out if this is a false push notification and if so, triggered by what.

n8fr8 commented 6 years ago

Can we just disable this notification? Too many false positives.

N-Pex commented 6 years ago

Please retest in build 134.

tiffrobo commented 6 years ago

So! Kaci was seeing this error, but I she has the app store version. I haven't seen it during testing build 134 or 135.

Device: iPhone 6, iPhone 7 OS: 10.3.3, 11.2.2 App version: build 135