search

zombeats / bloggy

Brand theme for Ghost. Demo @ https://zombeats.es
MIT License
28 stars 16 forks source link

Language not affected by footer code injection #8

Open hawkins opened 8 years ago

hawkins commented 8 years ago

Hello,

I've followed your instructions and included the bloggy.en_US.js script tag in the blog_footer code injection portion of the Ghost settings. However, the top-posts and subscribe buttons etc are still not in English.

Upon further investigation, I'm a little confused by the adaptability of this with hard-coded names in the JavaScript source code. Are users expected to modify your source code to adjust anything at all?

Kikobeats commented 8 years ago

Hello,

The multilanguage support is hard coded based in jQuery replace because currently I didn't found a better way to do that. I'm waiting Ghost Apps for improve this, but currently for me is enough.

All replace rules are here:

https://github.com/Kikobeats/bloggy/tree/master/assets/js/src/i18n

so basically I generate a build per each language. Default language is en.

Can you provide an screenshot of your problem?

hawkins commented 8 years ago

Gotcha, that explains it then.

This is what I see after including the US script tag in settings:

image

I was expecting the subscribe button and the top posts header to be in English after including the script per your instructions.