search

zombieFox / awesomeSheet

Online Pathfinder Character Sheet
https://zombiefox.github.io/awesomeSheet/
MIT License
152 stars 28 forks source link

Non existing negative #127

Open DigiBear opened 6 years ago

DigiBear commented 6 years ago

screenshot_20180113-140224

It seems that on samsung tablet devices at least the numeral input is triggered. The problem here being that it makes adding negatives impossible. This specific image was taken from a samsung galaxy tab a 10.1, I found that this problem is non existent on the One+ 3.

I sadly don't have any other devices to test it out on, I do believe the one+ 3 is considered the exeption here not the norm since the one+ 3 swift keyboard function has never given me a numerical pad.

Good luck!

zombieFox commented 6 years ago

Thanks for alerting me to this issue. I've tested on a Nexus 5, Pixel 2 XL, iPhone 6 and Samsung Chromebook Pro (tablet mode). All respective keyboards show a - (minus) key.

After some googling it seems like its a known issue with Samsung devices. Seems Samsung decided they wont show the minus character on <input type="number">.

stackoverflow post talking about this problem

I'm not sure how to resolve this short of changing all <input type="number">'s to <input type="text">. This is undesirable as I recently made the change to type="number".

Suggestions welcome.

DigiBear commented 6 years ago

I found my own work around by typing "-1" into a nearby text box and just using copy and paste, this is certainly not ideal though.

If it is however indeed only for a very specific type of device so far then I say that the bug is fairly low on the list of priorities so far. It might be very aesthetically unpleasant but having the incremental up and down inputs at the end of the box might be a reasonable hot fix.

zombieFox commented 6 years ago

Hm, that really is a painful workaround. Sorry.

I'm planning to review some analytic data and try to estimate how many users this problem may impact. I may have to restore <input type="text"> to deal with this. Watch this space.

DigiBear commented 6 years ago

Another quick fix I found for Samsung users is literally downloading any other keyboard than the Samsung keyboard. You can quite easily download the Swift or Google keyboard e.g. which will give you the minuses to work with.