zombieFox / awesomeSheet

Online Pathfinder Character Sheet
https://zombiefox.github.io/awesomeSheet/
MIT License
152 stars 29 forks source link

Bug: Armor Check Penalty is added to the Skill Bonus instead of substracted. #161

Closed mibib7 closed 6 years ago

mibib7 commented 6 years ago

image

image

As you can see, the total is calculated as Ranks (3) + Dex (3) + ACP (2) = 8. The real total should be Ranks (3) + Dex (3) - ACP (2) = 4.

I understand that I can just insert the ACP as an negative value for the calculation to be accurate, but considering that ACP can never be negative (as in giving a bonus instead of a malus) and that in the game material ACP is given as a positive value, it is confusing having to put a negative value.

zombieFox commented 6 years ago

Hi, actually I believe the Armor Check Penalty is always a negative number. It can never be a positive number. It is listed as negative numbers in the armor and shields section on the PRD.

As such the input for Armor Check Penalty is applied (or added) to Skills which accept it. So in the example above to calculate correctly ACP should be entered as a negative number: (Ranks 3) + (Dex 3) + (ACP -2) = 4.

mibib7 commented 6 years ago

You are right, my bad. Keep up the good work.

zombieFox commented 6 years ago

Thanks for taking time to feedback in any case.