zombieFox / awesomeSheet

Online Pathfinder Character Sheet
https://zombiefox.github.io/awesomeSheet/
MIT License
150 stars 28 forks source link

Print Mode Font Colour #166

Closed DigiBear closed 6 years ago

DigiBear commented 6 years ago

Hey, just a quick little bug I found.

When trying to print the page out the base font colour is retained. this means that when printing while in dark mode you'll have light gray text on a white background. Nothing bad or anything but thought I'd let you know!

zombieFox commented 6 years ago

That is an interesting scenario, I wouldn't call a problem as there is a way to work around this issue by switching to Display Mode before printing. That being said I wanted to explore the idea of detecting the print event and invoking a function. I've investigated and refactored the Minimise, Display Mode and Night Mode modules.

New functionality which will be released in a short while (I'm testing it now):

On print:

After print:

This ties in well with some other work I was doing involving preserving the active Tab state which will also roll out with this update.

zombieFox commented 6 years ago

Feature is now live.