search

zombieFox / awesomeSheet

Online Pathfinder Character Sheet
https://zombiefox.github.io/awesomeSheet/
MIT License
150 stars 28 forks source link

Update Build, Replace Bower #169

Closed johnantoni closed 6 years ago

johnantoni commented 6 years ago

Hi, I'm going to try and port the app to Yarn & Webpack

Is that ok? Any issues with using Yarn?

Just know that Bower is unmaintained and can probably get it running under webpack which could make future development easier.

zombieFox commented 6 years ago

Hi, I've not got much experience with Yarn and only know a bit about Webpack. But don't really mind what tooling to use. Would this be replacing Bower? Or Bower and Grunt?

johnantoni commented 6 years ago

it'd replace bower. grunt not sure about. probably keep that for the time being. Yarn is basically NPM with a few bells and whistles.

I'll start it and see how it goes, could be good.

johnantoni commented 6 years ago

Ok, had some good progress this weekend after the England game (woo hoo!)

Decided against adding webpack as that would technically replace grunt but there isn't really any need to as the build works so well.

What I have done is remove Bower as Bower is no longer maintained and referenced the scss/js the project needs to the node_modules directories which helped a lot.

I've also updated all the grunt and other packages referenced in the package.json so everything is up-to-date. Had to add node-sass and reference it in Gruntfile.js to provide the SASS compiler.

Updated the docs, works pretty well, it's pretty simple now:

yarn install

or if you use npm

npm install

Then either grunt dev or grunt build as before

Logged a pull request for you to review the changes, https://github.com/zombieFox/awesomeSheet/pull/170, let me know what you think @zombieFox

zombieFox commented 6 years ago

Amazing work. I really appreciate you taking the time. I'm reviewing the pull request now. Since this project is a learning exercise for me and I don't have a lot of experience with Yarn do you mind if I ask some questions? I'll add them to the relevant lines in the pull request. (Mainly things around best practices etc.)

I've pulled down your changes and it looks great so far. I'm doing some checks and test now -- but I don't see why it shouldn't be merged.

(Seems like everyone watched the England game but me! ⚽️)

johnantoni commented 6 years ago

no problem, glad you like it. gone thru the pull request and answered all your questions. please feel free to ask anything else.

Yep that game was a nail-biter so glad we're thru. First time since 1960, definitely check it out if you can they played great.