Update Build, Replace Bower

zombieFox / awesomeSheet

Online Pathfinder Character Sheet

https://zombiefox.github.io/awesomeSheet/

MIT License

150 stars 28 forks source link

Update Build, Replace Bower #170

Closed johnantoni closed 5 years ago

johnantoni commented 6 years ago

What's included:

Updated grunt packages, added node-sass as the SCSS compiler for the sass grunt task.
Remove Bower, as no longer maintained.
Update smoothScroll to latest and navBar.js to work with the updated library, naming changed from smoothScroll() to SmoothScroll().
Update readme.md to remove reference to Bower, as no longer needed.

Ready for review.

johnantoni commented 6 years ago

removed the /build directory from the git repo @zombieFox

johnantoni commented 5 years ago

@zombieFox good to merge in?

zombieFox commented 5 years ago

Apologies, I've had a busy couple of weeks (family in town). I spotted a few issues while testing last week and have been looking to resolve them. These include:

Smooth scrolling no long working with the clone.js module
Smooth scrolling incorrectly activating the wrong icons in the nav

I've got some fixes in place now. I'll attempt to add a commit to this PR.

zombieFox commented 5 years ago

Good to merge once the /build/ removal change is resolved.

johnantoni commented 5 years ago

Ok, the build dir should be ignored now on commits. Had to add the dir, remove it, then add it it gitignore commit and then build it again. after that looks to be no longer getting committed.

zombieFox commented 5 years ago

I'm still not sure how the build and deploy will work without a /build/ directory, I'm betting you have a plan. 😄