zombieyang / sd-ppp

Communicate between Photoshop and SD/SDForge/ComfyUI
MIT License
281 stars 9 forks source link

Impossible to make regional prompt works with photoshop 2024+ comfyui + Flux #38

Closed Elgokoo closed 3 months ago

Elgokoo commented 3 months ago

Hi,

Because the tutorial doesn't provide a workflow , I have tried to create mine with the example of the Orange / Strawberry / Apple, and the result is a merged image like you see below.

I have attached my workflow if you can provide a fix or a working workflow.

Thanks a lot for your help

ComfyUI_00335_

Photoshop regional.json

The log below could help :

WARNING: define_comfyui_nodes..GetTextFromLayerNode.IS_CHANGED() got an unexpected keyword argument 'document' WARNING: define_comfyui_nodes..GetTextFromLayerNode.IS_CHANGED() got an unexpected keyword argument 'document' WARNING: define_comfyui_nodes..GetTextFromLayerNode.IS_CHANGED() got an unexpected keyword argument 'layer_or_group' WARNING: define_comfyui_nodes..GetTextFromLayerNode.IS_CHANGED() got an unexpected keyword argument 'layer_or_group' WARNING: define_comfyui_nodes_legacy..GetImageFromPhotoshopLayerNode.IS_CHANGED() got an unexpected keyword argument 'document' WARNING: name 'layer' is not defined WARNING: name 'layer' is not defined !!! Exception during processing !!! 'NoneType' object is not subscriptable Traceback (most recent call last): File "D:\ComfyUI\execution.py", line 317, in execute output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb) File "D:\ComfyUI\execution.py", line 192, in get_output_data return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb) File "D:\ComfyUI\execution.py", line 169, in _map_node_over_list process_inputs(input_dict, i) File "D:\ComfyUI\execution.py", line 158, in process_inputs results.append(getattr(obj, func)(**inputs)) File "D:\ComfyUI\custom_nodes\sd-ppp\sdppp_python\comfy_nodes_legacy.py", line 85, in get_image document = layer_or_group['document'] TypeError: 'NoneType' object is not subscriptable

Elgokoo commented 3 months ago

It's so weird, your fix has a virus.

And can you please give me the instruction to fix it please ?

zombieyang commented 3 months ago

It's so weird, your fix has a virus.

And can you please give me the instruction to fix it please ?

please don't download that, I don't know him.

I need your workflow or just a screenshoot of what your workflow looks like to locate the problem.

my workflow and .psd will be uploaded in 3 or 4 hours.

Elgokoo commented 3 months ago

thanks for.your feedback,

I have already paste my custom workflow

https://github.com/user-attachments/files/16755688/Photoshop.regional.json

Thanks for.all what you doing and help

zombieyang commented 3 months ago

great, I've just get off work. 240827 workflow+psd.zip

Elgokoo commented 3 months ago

Oh Amazing, it works on dreamshaper Turbo, perfect, thanks a lot

Now I will try to make it work on "flux", but still unsure

PS : It would be great to update the Readme and workflow folder with these workflow to be sure this solution benefit for all

zombieyang commented 3 months ago

Oh Amazing, it works on dreamshaper Turbo, perfect, thanks a lot

Now I will try to make it work on "flux", but still unsure

PS : It would be great to update the Readme and workflow folder with these workflow to be sure this solution benefit for all

great!

the package above included a flux workflow (steel plate). Actually the biggest advanced of sdppp is that it only focus on getting/sending data so It won't confict with any other custom node.

All the sample workflows and psd is uploaded to my Discord already.