search

zombieyang / sd-ppp

Communicate between Photoshop and SD/SDForge/ComfyUI
MIT License
283 stars 9 forks source link

??? #60

Open SeBL4RD opened 1 day ago

SeBL4RD commented 1 day ago

Aren't we on Github here? Are you obfuscating your code? Is that legal? Ethical?

zombieyang commented 1 day ago

Appreciate for your following to sd-ppp. I did this for some reason:

  1. You can see another comfy-PS like plugin, which also switched to WebSocket after my first version. Always publish its code with Photoshop plugin minified.
  2. The new canvas helper of forge, publish with obfuscated. ref: stable-diffusion-webui-forge#1232 After seeing these, compared with my previous open-source work in gaming field. I think the rule is not the same in AI paint tooling field until now.

For the contributors of SD-PPP, I think it is also not a good time to totally open source all the thing, too. While I still keep refactoring large amounts of my code(in 1.3.0, I refactored 80% of my codes. Even in 1.5.0, I refactor 30% of codes). That is why I feel sorry for @tianlang0704 because I abandoned so many of his codes.

What I did is leaving a markdown here: https://github.com/zombieyang/sd-ppp/blob/main/typescripts/develop.md. If someone need the code for learning or bug fixing, I can give the permission.

In the future, I'll still open source it, if:

  1. sd-ppp is famous enough and not easy to be replaced by other project.
  2. I think the code structure is stable enough.
SeBL4RD commented 1 day ago

Appreciate for your following to sd-ppp. I did this for some reason:

  1. You can see another comfy-PS like plugin, which also switched to WebSocket after my first version. Always publish its code with Photoshop plugin minified.
  2. The new canvas helper of forge, publish with obfuscated. ref: stable-diffusion-webui-forge#1232 After seeing these, compared with my previous open-source work in gaming field. I think the rule is not the same in AI paint tooling field until now.

For the contributors of SD-PPP, I think it is also not a good time to totally open source all the thing, too. While I still keep refactoring large amounts of my code(in 1.3.0, I refactored 80% of my codes. Even in 1.5.0, I refactor 30% of codes). That is why I feel sorry for @tianlang0704 because I abandoned so many of his codes.

What I did is leaving a markdown here: https://github.com/zombieyang/sd-ppp/blob/main/typescripts/develop.md. If someone need the code for learning or bug fixing, I can give the permission.

In the future, I'll still open source it, if:

  1. sd-ppp is famous enough and not easy to be replaced by other project.
  2. I think the code structure is stable enough.

Okay, i would learn, could you share me the real code please?

zombieyang commented 13 hours ago

Sure, invatation sent