search

zombocom / derailed_benchmarks

Go faster, off the Rails - Benchmarks for your whole Rails app
2.96k stars 141 forks source link

Fix syntax error in older rubies that do not support a `rescue` or `ensure` without a `begin` #155

Closed syiin closed 4 years ago

syiin commented 4 years ago

not sure of the intent behind the ensure block but there was no preceding begin and the identation gave no clue so this was just my small fix

schneems commented 4 years ago

The ensure is required. But I forgot that’s not a syntax that works on older versions of Ruby. We need to explicitly wrap everything with begin/end for the ensure block to work correctly. Can you update the PR to wrap the whole task with begin/end.

syiin commented 4 years ago

The ensure is required. But I forgot that’s not a syntax that works on older versions of Ruby. We need to explicitly wrap everything with begin/end for the ensure block to work correctly. Can you update the PR to wrap the whole task with begin/end.

got it

syiin commented 4 years ago

Expected to find a manifest file inapp/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)

But did not, please create this file and use it to link any assets that need`

This seems to be the error causing the tests to fail?

schneems commented 4 years ago

Thanks for the PR! Can you send me another one to add Ruby 2.4.4 to the test matrix in .travis.yml?